Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validators list layout #165

Merged
merged 1 commit into from
May 30, 2022
Merged

feat: validators list layout #165

merged 1 commit into from
May 30, 2022

Conversation

taro04
Copy link
Contributor

@taro04 taro04 commented May 13, 2022

@YasunoriMATSUOKA , @Senna46

I thought it would be better to fix the position of the unit (M/G) and %.
((but The image does not seem to change much as below)
If you like this, please review

  • before
    20220513_before_sm
    20220513_before_lg

  • after
    20220513_after_sm
    20220513_after_lg

Senna46
Senna46 approved these changes May 14, 2022
View reviewed changes
Copy link
Collaborator

@Senna46 Senna46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@Senna46
Copy link
Collaborator

Senna46 commented May 14, 2022

This change will be also reflected in Portal. Plz wait for merging.

@Senna46 Senna46 mentioned this pull request May 30, 2022
Merged
@Senna46 Senna46 merged commit 6c6eac3 into develop May 30, 2022
@Senna46 Senna46 deleted the feature/validators-view branch May 30, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senna46 Senna46 Senna46 approved these changes

@YasunoriMATSUOKA YasunoriMATSUOKA Awaiting requested review from YasunoriMATSUOKA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taro04 @Senna46