feat: metamask support #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimurayu45z @jununifi Screenshot of connecting MetaMask |
|
@kimurayu45z @jununifi Screenshot of sending tx with MetaMask tx post response chain's log (log level = debug) frontend app's log |
|
Memo: Need to change from signTypedData_v4 to personal_sign |
|
@jununifi @kimurayu45z Screenshot |
YasunoriMATSUOKA
force-pushed
the
feature/metamask-support
branch
from
a62fcef
to
60150f4
Compare
|
@jununifi cc: @kimurayu45z |
kimurayu45z
reviewed
Jun 8, 2022
| const txJson = JSON.parse(txJsonString); | ||
|
|
||
| // fix JSONstringify issue | ||
| delete txJson.auth_info.signer_infos[0].mode_info.multi; |
There was a problem hiding this comment.
by using
cosmos-client/cosmos-client-ts#71
this PR, you can delete this line.
kimurayu45z
reviewed
Jun 8, 2022
| // fix JSONstringify issue | ||
| delete txJson.auth_info.signer_infos[0].mode_info.multi; | ||
| txJson.auth_info.signer_infos[0].mode_info.single.mode = 'SIGN_MODE_DIRECT'; | ||
| txJson.auth_info.fee.gas_limit = txJson.auth_info.fee.gas_limit.toString(); |
There was a problem hiding this comment.
this line also seems to be able to be removed.
Closed
Comment on lines
+18
to
+61
| private messageToDigest(message: string): Uint8Array { | ||
| const messageHash = ethers.utils.hashMessage(message); | ||
| const digest = ethers.utils.arrayify(messageHash); | ||
| return digest; | ||
| } | ||
|
|
||
| private async personalSign(message: string): Promise<string> { | ||
| await detectEthereumProvider({ mustBeMetaMask: true }); | ||
| if (!window.ethereum?.isMetaMask) { | ||
| throw Error('MetaMask is not installed!'); | ||
| } | ||
| const provider = new ethers.providers.Web3Provider(window.ethereum); | ||
| const accounts = await provider.send('eth_requestAccounts', []); | ||
| if (!accounts?.length) { | ||
| throw Error('Failed to get MetaMask account!'); | ||
| } | ||
| const address = accounts[0]; | ||
| console.log(address); | ||
| const signer = provider.getSigner(address); | ||
| const signature = signer.signMessage(message); | ||
| return signature; | ||
| } | ||
|
|
||
| private async getPublicKeyFromMetaMask(): Promise<string> { | ||
| const message = 'Connecting to MetaMask from UnUniFi'; | ||
| const signature = await this.personalSign(message); | ||
| console.log('signature', signature); | ||
| const recoveredAddress = ethers.utils.verifyMessage(message, signature); | ||
| console.log('ethRecoveredAddress', recoveredAddress); | ||
|
|
||
| const digest = this.messageToDigest(message); | ||
| console.log('digest', digest); | ||
| const recoveredUncompressedPublicKey = ethers.utils.recoverPublicKey(digest, signature); | ||
| console.log('ethUncompressedPublicKey', recoveredUncompressedPublicKey); | ||
| const recoverdAddress2 = ethers.utils.recoverAddress(digest, signature); | ||
| console.log('ethRecoveredAddress2', recoverdAddress2); | ||
| const recoveredCompressedPublicKey = ethers.utils.computePublicKey( | ||
| recoveredUncompressedPublicKey, | ||
| true, | ||
| ); | ||
| console.log('ethCompressedPublicKey', recoveredCompressedPublicKey); | ||
| const publicKeyWithout0x = recoveredCompressedPublicKey.slice(2); | ||
| return publicKeyWithout0x; | ||
| } |
There was a problem hiding this comment.
@jununifi
You can refer the procedure to get public key on front end side.
Comment on lines
+78
to
+94
| private async getCosmosStoredWalletFromMetaMask(): Promise<StoredWallet> { | ||
| const ethAddress = await this.getEthAddress(); | ||
| const publicKeyString = await this.getPublicKeyFromMetaMask(); | ||
| const cosmosPublicKey = createCosmosPublicKeyFromString(KeyType.secp256k1, publicKeyString); | ||
| if (!cosmosPublicKey) { | ||
| throw Error('Invalid public key!'); | ||
| } | ||
| const accAddress = cosmosclient.AccAddress.fromPublicKey(cosmosPublicKey); | ||
| const storedWallet: StoredWallet = { | ||
| id: ethAddress, | ||
| type: WalletType.metaMask, | ||
| key_type: KeyType.ethsecp256k1, | ||
| public_key: publicKeyString, | ||
| address: accAddress.toString(), | ||
| }; | ||
| return storedWallet; | ||
| } |
There was a problem hiding this comment.
@jununifi
You can refer the procedure to convert from public key to UnUniFi address.
signature verification failed
This should be reverted after fix
from SIGN_DIRECT to SIGN_MODE_DIRECT
- reference - ethers-io/ethers.js#447 (comment) - remove web3 - remove eth-sig-utils
YasunoriMATSUOKA
force-pushed
the
feature/metamask-support
branch
from
c76bd11
to
169de99
Compare
|
@kimurayu45z |
kimurayu45z
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jununifi
Because it seems your reference PR's branch ( #188 and https://github.com/UnUniFi/web-apps/tree/metamask_integration ) was checked out from main branch, I have created new branch and new PR with checking out from develop branch. I will implement this feature here.
Todos
Screenshots
Connect to MetaMask Image
