Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate landing page from angular spa to simple static html #199

Merged
merged 4 commits into from
Jun 8, 2022
Merged

refactor: migrate landing page from angular spa to simple static html #199

merged 4 commits into from
Jun 8, 2022

Conversation

taro04
Copy link
Contributor

@taro04 taro04 commented Jun 1, 2022 •
edited
Loading

Done: make html file and debug. fix CI and hosting on local emulator.
Todo: none

image

@YasunoriMATSUOKA YasunoriMATSUOKA changed the title [WIP] Feature/landing page html [WIP] refactor: migrate landing page from angular spa to simple static html Jun 2, 2022
@taro04 taro04 self-assigned this Jun 2, 2022
@taro04
Copy link
Contributor Author

taro04 commented Jun 2, 2022

[WIP] add git link

image

@taro04
Copy link
Contributor Author

taro04 commented Jun 6, 2022

@YasunoriMATSUOKA
Please, review.
I fix package.json, then checked that hosting on emulator.
I confirmed that the command "start:landing-page", "start:all" work right.
There may be other corrections, but I would like to ask you to confirm.

@taro04 taro04 changed the title [WIP] refactor: migrate landing page from angular spa to simple static html refactor: migrate landing page from angular spa to simple static html Jun 6, 2022
YasunoriMATSUOKA
YasunoriMATSUOKA approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YasunoriMATSUOKA YasunoriMATSUOKA merged commit 09660bb into develop Jun 8, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the feature/landing-page-html branch June 8, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasunoriMATSUOKA YasunoriMATSUOKA YasunoriMATSUOKA approved these changes

Assignees

@taro04 taro04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taro04 @YasunoriMATSUOKA