Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set the order of proposals in descending order #205

Merged
merged 1 commit into from
Jun 9, 2022
Merged

feat: Set the order of proposals in descending order #205

merged 1 commit into from
Jun 9, 2022

Conversation

taro04
Copy link
Contributor

@taro04 taro04 commented Jun 8, 2022

@YasunoriMATSUOKA , cc @kimurayu45z
Please. review.

  • before
    image

  • after
    image

In additional, should I set pagination to proposals?

YasunoriMATSUOKA
YasunoriMATSUOKA approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taro04

In additional, should I set pagination to proposals?

Let's do it in another PR.

LGTM

@YasunoriMATSUOKA YasunoriMATSUOKA merged commit 6b298d0 into develop Jun 9, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the feature/proposals-in-descending-order branch June 9, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasunoriMATSUOKA YasunoriMATSUOKA YasunoriMATSUOKA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taro04 @YasunoriMATSUOKA