-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the parse function to extract common elements of the tx #213
Conversation
I think that... So, the logic for parsing tx types is good. The remaining big problem is UI, I think. |
I think so. now, I still feel a lot of difficulty. (Especially Then, should I change the table head to an item common to Tx? |
@YasunoriMATSUOKA, @kimurayu45z I would like to change the table header like this. Please let us know if you have any other ideas. |
@YasunoriMATSUOKA, cc @kimurayu45z Please, review. 🙏 |
@taro04 |
Sorry, unintentionally modifying the marketplace was also the cause of the CI error. The build error is gone, but I'm updating Angular.json in this PR, so I think this PR should be merged after #236 merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@YasunoriMATSUOKA
Please review.
I extracted the information from tx.
7/15 types of tx were confirmed. I haven't reached any other types of tx.
I think it's enough to check with some types of tx.
But if you need to check for other types of tx, please tell me how to access that tx or the block height that contains the tx.
(Nothing appeared in the [gov] pull-down of explorer / transaction page.)
address
http://localhost:4200/explorer/accounts/ununifi1wehequ8gcwnf6kredpen49re6qddylk23aepca
MsgWithdrawDelegatorReward
http://localhost:4200/explorer/blocks/492901
MsgEditValidator
http://localhost:4200/explorer/blocks/134970
MsgCreateValidator
http://localhost:4200/explorer/blocks/17517
MsgUndelegate
http://localhost:4200/explorer/blocks/492911
MsgBeginRedelegate
http://localhost:4200/explorer/blocks/492886
MsgDelegate
http://localhost:4200/explorer/blocks/135036
MsgSend
http://localhost:4200/explorer/blocks/65485
(* chainID = 'create-validator-debug';)