Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: fix for release to disable metamask related features #226

Merged
merged 4 commits into from
Jun 20, 2022
Merged

revert: fix for release to disable metamask related features #226

merged 4 commits into from
Jun 20, 2022

Conversation

YasunoriMATSUOKA
Copy link
Contributor

@kimurayu45z @mkXultra
plz review 🙏

@YasunoriMATSUOKA YasunoriMATSUOKA self-assigned this Jun 20, 2022
@mkXultra
Copy link
Contributor

@YasunoriMATSUOKA
this is not exists file change.
is it ok?

@YasunoriMATSUOKA
Copy link
Contributor Author

@mkXultra

this is not exists file change.
is it ok?

I think it's OK.
This change has the following histories.

  1. Disable MetaMask related feature for beta-test(=release branch) and main(=main branch)
  2. Enable MetaMask related feature for alpha-test(=develop branch)

Then, there is no changes at conclusion but I think it is important to exist such commit histories.
(But, I'm not sure...)

@YasunoriMATSUOKA YasunoriMATSUOKA merged commit aa5129a into develop Jun 20, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the feature/fix-for-release-to-disable-metamask-related-features branch June 20, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkXultra mkXultra mkXultra approved these changes

@kimurayu45z kimurayu45z Awaiting requested review from kimurayu45z

Assignees

@YasunoriMATSUOKA YasunoriMATSUOKA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YasunoriMATSUOKA @mkXultra