Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for shared/util #242

Merged
merged 8 commits into from
Jul 7, 2022
Merged

Add tests for shared/util #242

merged 8 commits into from
Jul 7, 2022

Conversation

uuyu-g
Copy link
Contributor

@uuyu-g uuyu-g commented Jul 5, 2022 •
edited
Loading

Target

  • converter
  • key
  • validation

Other

  • update vscode/setting.json "jest.jestCommandLine": "ng test" to jest
  • fix shared/nft.component.spec

@uuyu-g uuyu-g changed the title Add tests for shared/util [WIP] Add tests for shared/util Jul 5, 2022
@uuyu-g uuyu-g force-pushed the chore/shared/test/utils/converter branch 3 times, most recently from d403834 to eba1104 Compare July 5, 2022 08:42
@uuyu-g uuyu-g changed the title [WIP] Add tests for shared/util Add tests for shared/util Jul 5, 2022
@uuyu-g
Copy link
Contributor Author

uuyu-g commented Jul 5, 2022

@YasunoriMATSUOKA
plz review in your good time.

YasunoriMATSUOKA
YasunoriMATSUOKA approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uuyu-g uuyu-g mentioned this pull request Jul 6, 2022
Merged
2 tasks
@uuyu-g uuyu-g force-pushed the chore/shared/test/utils/converter branch from eba1104 to a0ff094 Compare July 6, 2022 02:15
@YasunoriMATSUOKA
Copy link
Contributor

@yutaro-elk
Sorry, I just want to make sure, should I merge this once?

@uuyu-g
Copy link
Contributor Author

uuyu-g commented Jul 7, 2022

@YasunoriMATSUOKA
I thought the reviewers would merge.
I'll merge if i can.

@YasunoriMATSUOKA
Copy link
Contributor

@yutaro-elk
Thank you. I'll merge this.

@YasunoriMATSUOKA YasunoriMATSUOKA merged commit e0e1065 into develop Jul 7, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the chore/shared/test/utils/converter branch July 7, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasunoriMATSUOKA YasunoriMATSUOKA YasunoriMATSUOKA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uuyu-g @YasunoriMATSUOKA