Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: IYA APR Info #631

Merged
merged 25 commits into from
Sep 4, 2023
Merged

feat: IYA APR Info #631

merged 25 commits into from
Sep 4, 2023

Conversation

Senna46
Copy link
Collaborator

@Senna46 Senna46 commented Aug 31, 2023

Changes

  • To be able to specify a range for APR (APY)
  • Indicates whether it is a secure APR or an estimated APR

kimurayu45z
kimurayu45z reviewed Sep 1, 2023
View reviewed changes
projects/portal/src/app/models/config.service.ts Outdated
apy: number;
min_apy: number;
max_apy: number;
apr_certainty: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_estimation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix to certainty

@Senna46 Senna46 merged commit 9d98c18 into develop Sep 4, 2023
1 check passed
@Senna46 Senna46 deleted the apr-range branch September 4, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimurayu45z kimurayu45z kimurayu45z left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senna46 @kimurayu45z