Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proposal list page, proposal details page, deposit form dialog and voting form dialog #74

Merged
merged 16 commits into from
Apr 20, 2022
Merged

feat: proposal list page, proposal details page, deposit form dialog and voting form dialog #74

merged 16 commits into from
Apr 20, 2022

Conversation

Senna46
Copy link
Collaborator

@Senna46 Senna46 commented Apr 18, 2022 •
edited
Loading

to do

  • /portal/vote/proposals
    • display & vote dialog
  • /portal/vote/proposals/{proposal_id}
    • vote dialog
    • deposit dialog
  • /dialogs/vote/vote-form-dialog
  • /dialogs/vote/deposit-form-dialog

@Senna46
Copy link
Collaborator Author

Senna46 commented Apr 18, 2022

Temporary UI

  • Proposal List
    screencapture-localhost-4200-portal-vote-proposals-2022-04-18-18_14_20

  • Proposal Detail
    screencapture-localhost-4200-portal-vote-proposals-1-2022-04-18-18_14_36

@Senna46
Copy link
Collaborator Author

Senna46 commented Apr 18, 2022

  • deposit-form-dialog
    スクリーンショット 2022-04-18 202641

  • deposit result
    スクリーンショット 2022-04-18 202429

  • vote dialog
    screencapture-localhost-4200-portal-vote-proposals-2022-04-18-20_25_59

  • vote result
    Can not vote in DEPOSIT_PERIOD. I will check the operation after tomorrow.

@Senna46 Senna46 mentioned this pull request Apr 18, 2022
Merged
5 tasks
@Senna46 Senna46 added the enhancement New feature or request label Apr 19, 2022
@Senna46
Copy link
Collaborator Author

Senna46 commented Apr 20, 2022

This function will be checked after 2022-04-20T06:29:00.303994616Z (4/20 15:30 JST).

@Senna46 Senna46 changed the title [WIP] feat: proposal function feat: proposal function Apr 20, 2022
@Senna46
Copy link
Collaborator Author

Senna46 commented Apr 20, 2022

  • Proposal parameters are now displayed on the detail page.
    screencapture-localhost-4200-portal-vote-proposals-3-2022-04-20-19_34_35

The Vote function works perfectly!.
I will apply the same changes to Explorer, so please wait!

@Senna46
Copy link
Collaborator Author

Senna46 commented Apr 20, 2022

Done
@YasunoriMATSUOKA plz review

@YasunoriMATSUOKA YasunoriMATSUOKA changed the title feat: proposal function feat: proposal list page, proposal details page, deposit form dialog and voting form dialog Apr 20, 2022
YasunoriMATSUOKA
YasunoriMATSUOKA approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Senna46 Senna46 merged commit 86464b5 into develop Apr 20, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the feature/proposal-function branch April 22, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasunoriMATSUOKA YasunoriMATSUOKA YasunoriMATSUOKA approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senna46 @YasunoriMATSUOKA