Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: minimum gas price readonly #93

Merged
merged 2 commits into from
Apr 20, 2022
Merged

hotfix: minimum gas price readonly #93

merged 2 commits into from
Apr 20, 2022

Conversation

Senna46
Copy link
Collaborator

@Senna46 Senna46 commented Apr 20, 2022

Chages

  • Minimum Gas Price can now be entered on following components.
    • delegate form
    • redelegate form
    • undelegate form
    • create validator page

@YasunoriMATSUOKA plz review

@Senna46 Senna46 added the bug Something isn't working label Apr 20, 2022
YasunoriMATSUOKA
YasunoriMATSUOKA suggested changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senna46
plz check comments and fix create-validator 🙏

projects/portal/src/app/views/staking/create-validator/create-validator.component.html Outdated
@@ -245,11 +206,11 @@ <h4 class="pt-3">Gas Settings</h4>
type="number"
[min]="0"
required
readonly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is not for general user. So, in this component, this settings should be readonly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this component, expected behavior is all form can't be edited.

@Senna46 Senna46 mentioned this pull request Apr 20, 2022
Merged
@YasunoriMATSUOKA YasunoriMATSUOKA changed the title fix: minimum gas price readonly hotfix: minimum gas price readonly Apr 20, 2022
YasunoriMATSUOKA
YasunoriMATSUOKA approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@YasunoriMATSUOKA YasunoriMATSUOKA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YasunoriMATSUOKA YasunoriMATSUOKA merged commit 1c7ab03 into main Apr 20, 2022
@YasunoriMATSUOKA YasunoriMATSUOKA deleted the hotfix/minimum-gas-price-readonly branch April 20, 2022 05:17
@Senna46 Senna46 mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasunoriMATSUOKA YasunoriMATSUOKA YasunoriMATSUOKA approved these changes

Assignees

@Senna46 Senna46

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senna46 @YasunoriMATSUOKA