Apparent temperature working with scalars #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it's really worth all that code rather than just use |
|
Ugh, that would make behavior different between |
jrleeman
force-pushed
the
apparent_temperature_scalar
branch
from
f27d275
to
e6bf585
Compare
jrleeman
force-pushed
the
apparent_temperature_scalar
branch
from
e6bf585
to
fe88f23
Compare
dopplershift
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #833 in a rather clunky way, but the only reliable way I could find. If we find we use the logic other places, it might be a good decorator, but that seems like overkill for now.