Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thermo.py #856

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Update thermo.py #856

merged 1 commit into from
Jun 4, 2018

Conversation

JoyMonteiro
Copy link
Contributor

@JoyMonteiro JoyMonteiro commented May 19, 2018 •
edited by dopplershift
Loading

Fix docstring for wet bulb temperature function.

Fixes #854.

@JoyMonteiro
Update thermo.py
bce9773 
Fix docstring for wet bulb temperature function.
@CLAassistant
Copy link

CLAassistant commented May 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JoyMonteiro JoyMonteiro mentioned this pull request May 19, 2018
Closed
dopplershift
dopplershift approved these changes May 19, 2018
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the fix and for your first PR to MetPy!

@dopplershift
Copy link
Member

Travis failure is unrelated, only failing on 3.4, and is truly puzzling. I'm tempted to just go ahead and merge this.

@dopplershift dopplershift mentioned this pull request May 19, 2018
Closed
@JoyMonteiro
Copy link
Contributor Author

JoyMonteiro commented May 19, 2018 •
edited
Loading

I have seen the same issue in my own project. This is related to the latest version of pandas (0.22) not playing well with the latest pip (10.0)

pandas-dev/pandas#20697

@dopplershift
Copy link
Member

Thanks for letting me know about that. It's still probably time to drop 3.4, since when MetPy 0.9 is released, we would otherwise be supporting 3.4, 3.5, 3.6, and 3.7. See #813 if you have any thoughts on the matter of what versions of things to support.

@dopplershift dopplershift added Type: Bug Something is not working like it should Area: Docs Affects documentation Area: Calc Pertains to calculations labels May 25, 2018
@dopplershift dopplershift added this to the 0.9 milestone May 25, 2018
@jrleeman
Copy link
Contributor

jrleeman commented Jun 4, 2018

@JoyMonteiro - Send your mailing address to me (jleeman@ucar.edu) if you'd like a snazzy MetPy Contributor sticker!

@dopplershift - I'd say let's just merge over this and shortly pull 3.4 from the matrix.

@dopplershift dopplershift merged commit bdd643f into Unidata:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@jrleeman jrleeman Awaiting requested review from jrleeman

Assignees
No one assigned
Labels
Area: Calc Pertains to calculations Area: Docs Affects documentation Type: Bug Something is not working like it should
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@JoyMonteiro @CLAassistant @dopplershift @jrleeman