Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for v1.4.0 release #227

Merged
merged 23 commits into from
Jan 31, 2021
Merged

prepare for v1.4.0 release #227

merged 23 commits into from
Jan 31, 2021

Conversation

jswhit
Copy link
Collaborator

@jswhit jswhit commented Jan 30, 2021

cftime.datetime now no longer uses calendar-specific sub-classes. Legacy functions (including calendar-specific subclasses) now kept in a separate file (_cftime_legacy.pyx).

@jswhit
Copy link
Collaborator Author

jswhit commented Jan 31, 2021

@spencerkclark - would you mind running the xarray tests again on this branch before I make a release? I decided to remove the calendar-specific sub-classes from cftime.datetime and I want to make sure that doesn't break anything. (datetime.__add__, datetime.__sub__ and num2date used to return the calendar specific sub-classes)

@spencerkclark
Copy link
Collaborator

That's nice, and it looks like you kept the ability to import the calendar-specific sub-classes, which we do still use in the xarray tests (we can probably migrate away from that at some point). I ran the tests with this branch and everything passed.

@jswhit
Copy link
Collaborator Author

jswhit commented Jan 31, 2021

thanks @spencerkclark. merging now.

@jswhit jswhit merged commit 0b95e72 into master Jan 31, 2021
@jswhit jswhit deleted the v1.4.0rel branch January 31, 2021 22:33
@spencerkclark
Copy link
Collaborator

That's nice, and it looks like you kept the ability to import the calendar-specific sub-classes, which we do still use in the xarray tests (we can probably migrate away from that at some point). I ran the tests with this branch and everything passed.

@jswhit unfortunately I think the fact that the xarray test suite uses the legacy types prevented it from catching some (fairly serious) errors that arose when using the new universal cftime.datetime objects. Perhaps making that change was a bit premature after all. Would you be open to reverting that change and issuing a patch release? Since this was my mistake, I'd be happy to take on the work of writing the PR to revert those additional changes.

@spencerkclark
Copy link
Collaborator

xref: pydata/xarray#4853

@spencerkclark
Copy link
Collaborator

@jswhit many thanks for issuing the 1.4.1 release! I missed it a few days ago because it did not show up in the "Releases" section on the GitHub repo homepage.

Screen Shot 2021-02-05 at 2 53 36 PM

Is there a way to update that too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants