-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for v1.4.0 release #227
Conversation
@spencerkclark - would you mind running the xarray tests again on this branch before I make a release? I decided to remove the calendar-specific sub-classes from cftime.datetime and I want to make sure that doesn't break anything. ( |
That's nice, and it looks like you kept the ability to import the calendar-specific sub-classes, which we do still use in the xarray tests (we can probably migrate away from that at some point). I ran the tests with this branch and everything passed. |
thanks @spencerkclark. merging now. |
@jswhit unfortunately I think the fact that the xarray test suite uses the legacy types prevented it from catching some (fairly serious) errors that arose when using the new universal |
xref: pydata/xarray#4853 |
@jswhit many thanks for issuing the 1.4.1 release! I missed it a few days ago because it did not show up in the "Releases" section on the GitHub repo homepage. Is there a way to update that too? |
cftime.datetime
now no longer uses calendar-specific sub-classes. Legacy functions (including calendar-specific subclasses) now kept in a separate file (_cftime_legacy.pyx
).