Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--disable-utilities causes test failure #313

Closed
WardF opened this issue Aug 31, 2016 · 3 comments
Closed

--disable-utilities causes test failure #313

WardF opened this issue Aug 31, 2016 · 3 comments

Comments

@WardF
Copy link
Member

WardF commented Aug 31, 2016

As originally reported in issue EDB-648764


In netcdf-C 4.4.1, the autotools configure option --disable-utilities
causes this make check failure:

FAIL: run_diskless.sh

nc_test/run_diskless.sh.log says:

./run_diskless.sh: line 103: ../ncdump/ncdump: No such file or directory
FAIL run_diskless.sh (exit status: 1)

This is an extremely minor problem of course, but I thought I should report
it. It seems to me that one of these remedies should be added:

  1. Guard this test and others like it, so they do not fail on missing
    utilities.
  2. Add a comment in the options documentation next to --disable-utilities,
    something to the effect of "Utilities must remain enabled for normal
    operation of the test suite".

http://www.unidata.ucar.edu/software/netcdf/docs/getting_and_building_netcdf.html#configure_options

Please add one of these at your convenience, or let me know if there is
something better. Thanks.

@WardF
Copy link
Member Author

WardF commented Aug 31, 2016

When -DENABLE_UTILITIES=OFF is passed in a cmake-based build multiple tests fail:

 17 - nc_test_run_diskless (Failed)
 18 - nc_test4_run_grp_rename (Failed)
 20 - nc_test4_tst_misc (Failed)
 54 - nc_test4_tst_xplatform (Failed)
110 - ncdap_tst_remote3 (Failed)
111 - ncdap_tst_formatx (Failed)

I suspect they also need to be fenceposted.

@WardF
Copy link
Member Author

WardF commented Aug 31, 2016

Turns out the other tests happen in autotools-based tests as well, they just aren't reached because make check bails before they are run.

WardF added a commit that referenced this issue Aug 31, 2016
… utilities were not built, in autoconf-based tests. See #313 for more information.
@WardF
Copy link
Member Author

WardF commented Sep 1, 2016

Resolved.

@WardF WardF closed this as completed Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant