v4.7.4 Development Branch upstream from 4.7.3 #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern CMake tracks the properties of targets so that down stream libraries do not have to worry about include directories. However, the include directories must be added to the target and not just at the directory level.
The usual convention with modern CMake is to namespace the targets. This gives the netCDF namespace to the package.
…df-c into v4.7.3-wellspring.wif
…netcdf-c into v4.7.3-wellspring.wif
…nto v4.7.3-wellspring.wif
…nto v4.7.3-wellspring.wif
The CMakeLists.txt actually uses `HDF5_C_LIBRARY` and `HDF5_HL_LIBRARY` to find non-standard HDF5 installation. This just updates the FAQ with the correct usage.
…df-c into v4.7.3-wellspring.wif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the selective merge of changes from the v4.7.3 wellspring branch back in to
master, in preparation of the 4.7.3 branch. General reminder, changes propagate in one direction from this branch in tomasterandv4.7.3-prep.wif.