Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counting of dimensions in ncdump #2004

Merged
merged 2 commits into from
May 19, 2021
Merged

Fix counting of dimensions in ncdump #2004

merged 2 commits into from
May 19, 2021

Commits on May 18, 2021

  1. Fix counting of dimensions in ncdump 

    re: issue Unidata#2002

It turns out that ncdump has an error where it assumes that the set of all dimension ids has no holes. That is that (maxid+1) = ndims. This is incorrect for a variety of reasons for netcdf-4.

So instead of counting total number of dimensions in a dataset, it is necessary to look for the maximum dimension id and use that when allocating a table of all dimensions.
    @DennisHeimbigner
    DennisHeimbigner committed May 18, 2021
    Configuration menu
    Copy the full SHA
    fbd0d73 View commit details
    Browse the repository at this point in the history

  2. Update Release Notes

    @DennisHeimbigner
    DennisHeimbigner committed May 18, 2021
    Configuration menu
    Copy the full SHA
    c56133d View commit details
    Browse the repository at this point in the history