Fix macro usage #2618
Merged
Fix macro usage #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the other hand, I read over the comment in the code and am not sure about the solution anymore. |
|
Taking a look, I believe the inverse change (modifying the header file) should be made, but I am testing that now. |
WardF
approved these changes
Feb 27, 2023
ZedThree
added a commit
to ZedThree/netcdf-c
that referenced
this pull request
Mar 7, 2023
* main: (1776 commits) Invert solution as discussed at Unidata#2618 Correct a potential null pointer dereference. Fix a logic error that was resulting in an easy-to-miss error when running configure. Fix issue with dangling test file not getting cleaned up. Turn nczarr zip support off by default in cmake, add a status line indicating whether nczarr-zip-support is available, in libnetcdf.settings. Update the version of the cache action used by github action from v2 to v3. Explicit cast to unsigned char. More issues returned by sanitizer, related to attempts to assign MAX_UNSIGNED_CHAR (255) to a variable of type char. Fixed an issue where memcpy was potentially passed a null pointer. Correct another uninitialized issue. Correct undefined variable error. Fixing issues uncovered by compiling with '-fsanitize=undefined' and running nc_test/nc_test, in support of Unidata#1983, amongst others. The cast as was being used was undefined behavior, and had to be worked around in a style approximating C++'s 'reinterpret_cast' Remove a stray character at the head file. Fix a distcheck failure with nczarr_test/run_interop.sh Turn benchmarks off by default. They require netcdf4, additional logic is required in order to have them on by default. Add execute bit to test scripts Fix missing endif statement Add generated parallel tests for nc_perf, cmake-based build system. Correct typo in CMakeLists.txt Wiring performance benchmarks into cmake, cleaned up serial compression performance test dependency on MPI. ...
clrpackages
pushed a commit
to clearlinux-pkgs/netcdf
that referenced
this pull request
Mar 22, 2023
Dennis Heimbigner (9):
Modify H5FDhttp.c to work with HDF5 1.14.0
update release notes
Enable ACCEPT_ENCODING on DAP requests
Update Release notes
Fix a distcheck failure with nczarr_test/run_interop.sh
Extend the dispatch table for H5FD back to version 1.13.2
update RELEASENOTES
Missed one occurrence of 1,14,0
Fix byterange handling of some URLS
Greg Sjaardema (1):
Missing `goto`
Magnus Ulimoen (1):
Fix setting dest for non-m4 path
Mathieu Westphal (1):
Avoid optionnaly depends on zip for NCZarr
Sergey Kosukhin (1):
Fix macro usage
Ward Fisher (35):
Update release notes, prepare to merge back upstream into development branch.
Escape command symbol in doxygen template.
Incorporate fix in support of Unidata/netcdf-c#2437 (comment)
Update nc-config in support of Unidata/netcdf-c#2274
Added benchmarking option to cmake-based builds, turned on unit-testing by default
Wiring performance benchmarks into cmake, cleaned up serial compression performance test dependency on MPI.
Correct typo in CMakeLists.txt
Add generated parallel tests for nc_perf, cmake-based build system.
Fix missing endif statement
Add execute bit to test scripts
Turn benchmarks off by default. They require netcdf4, additional logic is required in order to have them on by default.
Remove a stray character at the head file.
Fixing issues uncovered by compiling with '-fsanitize=undefined' and running nc_test/nc_test, in support of Unidata/netcdf-c#1983, amongst others. The cast as was being used was undefined behavior, and had to be worked around in a style approximating C++'s 'reinterpret_cast'
Correct undefined variable error.
Correct another uninitialized issue.
Fixed an issue where memcpy was potentially passed a null pointer.
More issues returned by sanitizer, related to attempts to assign MAX_UNSIGNED_CHAR (255) to a variable of type char.
Explicit cast to unsigned char.
Update the version of the cache action used by github action from v2 to v3.
Turn nczarr zip support off by default in cmake, add a status line indicating whether nczarr-zip-support is available, in libnetcdf.settings.
Fix issue with dangling test file not getting cleaned up.
Fix a logic error that was resulting in an easy-to-miss error when running configure.
Correct a potential null pointer dereference.
Invert solution as discussed at Unidata/netcdf-c#2618
Bumped SO version.
Update release notes.
Bump version strings to reflect next development version.
Correct jsonconvention map with netcdf version.
Add hdf5 1.14.0 to GitHub CI.
Expand CI testing with HDF5 1.14.0
Set version strings.
Adjust reference nczarr file for v4.9.2 release.
Update .gitignore to allow generated files into version control for 4.9.2 release.
Added generated files for release.
Added generated test files for a stand-alone release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes configuration with
--disable-parallel4 --enable-pnetcdf. It looks likeNC_FILE_INFOhas thecommmember (i.e.grp->nc4_info->commis valid) only ifUSE_PARALLEL4is defined (see here).