Fix nullptr exception #1355
Merged
Fix nullptr exception #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
force-pushed
the
fix-nullptr-in-agg
branch
from
0ee0a9d
to
bbd876d
Compare
haileyajohnson
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
NcML aggregations are calling
UrlNaming.resolveFilewith the dataset URL as thebaseDirand the netcdf location as thefilepath. This is causing a nullptr exception in theMFileOS::getParentcall when the dataset URL does not have any slashes so the parent is null. Maybe this function should not be called at all in this case (the URL is not a baseDir so it is a bit weird), but in any case this nullptr exception should be fixed. This PR fixes the nullptr exception inMFileOSand adds unit tests.