Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Change XSLT version from 1.0 to 2.0 #805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cofinoa
Copy link
Contributor

@cofinoa cofinoa commented Apr 15, 2017

The XSLT document is using features from version 2.0 but the header mentions version 1.0.

For example for the some xsl:variable elements the as attribute is been used.

[version 1.0] https://www.w3.org/TR/xslt#variables
[version 2.0] https://www.w3.org/TR/xslt20/#variables

The XSLT document is using features from version 2.0 but the header mentions version 1.0. 

For example for the some `xsl:variable` elements the `as` attribute is been used. 

[version 1.0] https://www.w3.org/TR/xslt#variables
[version 2.0] https://www.w3.org/TR/xslt20/#variables
@cwardgar
Copy link
Contributor

@lesserwhirls Should this change be made to threddsIso instead? Why do we have duplicate files in the first place? I'm not really sure how the iso stuff works.

@lesserwhirls
Copy link
Collaborator

Things are a bit interesting for threddsIso. The code lives in the threddsIso repository, and the canonical transforms and other resource files live there as well. From what I understand, we have to manually pull those over to the THREDDS code base to make sure they are accessible in the thredds.war file we create.

Currently there is a PR (threddsIso#31) to update UnidataDD2MI.xsl to use ACDD 1.3, although that PR still uses version 1.0 in the header. I'll mention this PR in that PR to see if @noaaroland can include the change.

@lesserwhirls
Copy link
Collaborator

Actually, the xls files in @noaaroland's PR do not use as, so maybe not an issue anymore? Once his PR is accepted, then we can copy over those new transforms to use in the TDS.

@cwardgar cwardgar requested review from JohnLCaron and removed request for JohnLCaron April 17, 2017 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants