cleanup Integration tests #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
snreynolds
requested changes
Feb 18, 2024
| ERC20 tokenIn = DAI; | ||
| ERC20 tokenOut = USDC; | ||
| // gas token diff than tokenIn to test the sweep | ||
| ERC20 gasToken = USDC; |
There was a problem hiding this comment.
just a note but its definitely odd UX to have exact output swap where gasToken is in the same output token cause the end balance won't be the specified "exact"
| @@ -28,7 +28,7 @@ contract FeeEscalatorLibTest is Test { | |||
| assertEq(FeeEscalatorLib.resolve(1 ether, 2 ether, 100, 200), 1 ether); | |||
| } | |||
|
|
|||
| function testRelayFeeEscalation() public { | |||
| function test_resolve() public { | |||
There was a problem hiding this comment.
test_resolve_midwayEscalation?
| vm.expectRevert(ReactorErrors.EndTimeBeforeStartTime.selector); | ||
| FeeEscalatorLib.resolve(1 ether, 2 ether, 200, 100); | ||
| } | ||
|
|
||
| function testRelayFeeEscalationEqualAmounts(uint256 amount, uint256 startTime, uint256 endTime) public { | ||
| function test_resolve_equalAmounts(uint256 amount, uint256 startTime, uint256 endTime) public { |
There was a problem hiding this comment.
test_fuzz_resolve_equalAmounts_doesNotEscalate
| function testRelayFeeEscalationBounded(uint256 startAmount, uint256 endAmount, uint256 startTime, uint256 endTime) | ||
| public | ||
| { | ||
| function test_resolve_bounded(uint256 startAmount, uint256 endAmount, uint256 startTime, uint256 endTime) public { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.