Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sanity check integ tests for GET endpoint. #216

Merged
merged 2 commits into from
Jun 9, 2023
Merged

feat: add sanity check integ tests for GET endpoint. #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82280ad
feat: add sanity check integ tests for GET endpoint.
rileydcampbell Jun 9, 2023
6b19d34
Merge branch 'main' of https://github.com/Uniswap/gouda-service into …
rileydcampbell Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 48 additions & 10 deletions test/integ/order.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import { PERMIT2, UNI, WETH, ZERO_ADDRESS } from './constants'

const { DutchLimitOrderReactor__factory } = factories

import { FILL_EVENT_LOOKBACK_BLOCKS_ON } from '../../lib/handlers/check-order-status/handler'
import { GetOrdersResponse } from '../../lib/handlers/get-orders/schema'
import { ChainId } from '../../lib/util/chain'
import * as ERC20_ABI from '../abis/erc20.json'
import * as PERMIT2_ABI from '../abis/permit2.json'
import { FILL_EVENT_LOOKBACK_BLOCKS_ON } from '../../lib/handlers/check-order-status/handler'
const { abi } = ERC20_ABI
const { abi: permit2Abi } = PERMIT2_ABI

Expand Down Expand Up @@ -52,7 +52,7 @@ describe('/dutch-auction/order', () => {
// Fork management
let snap: null | string = null
let checkpointedBlock: ethers.providers.Block
let blockOffsetCounter: number = 0
let blockOffsetCounter = 0

beforeAll(async () => {
if (!process.env.GOUDA_SERVICE_URL) {
Expand All @@ -66,9 +66,7 @@ describe('/dutch-auction/order', () => {
provider = new ethers.providers.JsonRpcProvider(process.env.RPC_12341234)
// advance blocks to avoid mixing fill events with previous test runs
const startingBlockNumber = (await provider.getBlock('latest')).number
await provider.send('evm_increaseBlocks', [ethers.utils.hexValue(
INTIAL_BLOCK_OFFSET
)])
await provider.send('evm_increaseBlocks', [ethers.utils.hexValue(INTIAL_BLOCK_OFFSET)])
expect((await provider.getBlock('latest')).number).toEqual(startingBlockNumber + INTIAL_BLOCK_OFFSET)

alice = ethers.Wallet.createRandom().connect(provider)
Expand Down Expand Up @@ -304,12 +302,46 @@ describe('/dutch-auction/order', () => {
)

populatedTx.gasLimit = BigNumber.from(700_000)

const tx = await filler.sendTransaction(populatedTx)
const receipt = await tx.wait()
return receipt.transactionHash
}

describe('endpoint sanity checks', () => {
it.each([
[{ orderStatus: 'open' }],
[{ chainId: 1 }],
[{ orderStatus: 'expired' }],
[{ offerer: '0x0000000000000000000000000000000000000000' }],
[{ filler: '0x0000000000000000000000000000000000000000' }],
[{ orderStatus: 'expired', sortKey: 'createdAt', chainId: 137 }],
[{ orderStatus: 'expired', sortKey: 'createdAt', desc: false }],
[{ orderStatus: 'expired', sortKey: 'createdAt', desc: true }],
[{ orderStatus: 'expired', offerer: '0x0000000000000000000000000000000000000000' }],
[{ orderStatus: 'expired', filler: '0x0000000000000000000000000000000000000000' }],
[{ orderHash: '0x0000000000000000000000000000000000000000000000000000000000000000' }],
[
{
orderHashes:
'0x0000000000000000000000000000000000000000000000000000000000000000,0x0000000000000000000000000000000000000000000000000000000000000000',
},
],
])(
'Fetches orders with the following query param %p',
async (queryFilters: { [key: string]: string | boolean | number }) => {
const params = Object.keys(queryFilters)
const queryParams = params.reduce((acc, key) => {
const value = `${acc}${key}=${queryFilters[key]}`
return key == params[params.length - 1] ? value : value + '&'
}, '')

const resp = await axios.get<GetOrdersResponse>(`${URL}dutch-auction/orders${queryParams}`)
expect(resp.status).toEqual(200)
}
)
})

describe('checking expiry', () => {
it('erc20 to erc20', async () => {
const amount = ethers.utils.parseEther('1')
Expand All @@ -334,7 +366,7 @@ describe('/dutch-auction/order', () => {
})

const advanceBlocks = async (numBlocks: number) => {
if(numBlocks == 0) {
if (numBlocks == 0) {
return
}
await provider.send('evm_increaseBlocks', [ethers.utils.hexValue(numBlocks)])
Expand Down Expand Up @@ -406,14 +438,20 @@ describe('/dutch-auction/order', () => {
await fillOrder(order2, sig2)
expect(true).toBeFalsy()
} catch (err: any) {
expect(err.message.includes('transaction failed')).toBeTruthy();
expect(err.message.includes('transaction failed')).toBeTruthy()
}
expect(await waitAndGetOrderStatus(order2.hash(), 0)).toBe('cancelled')
})

it('allows same offerer to post multiple orders with different nonces and be filled', async () => {
const amount = ethers.utils.parseEther('1')
const { order: order1, signature: sig1 } = await buildAndSubmitOrder(aliceAddress, amount, DEFAULT_DEADLINE_SECONDS, WETH, UNI)
const { order: order1, signature: sig1 } = await buildAndSubmitOrder(
aliceAddress,
amount,
DEFAULT_DEADLINE_SECONDS,
WETH,
UNI
)
nonce = nonce.add(1)
const { order: order2, signature: sig2 } = await buildAndSubmitOrder(
aliceAddress,
Expand Down