Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSC - Decimal Fix & Graph-ts Upgade #200

Merged
merged 6 commits into from
Feb 26, 2024
Merged

BSC - Decimal Fix & Graph-ts Upgade #200

merged 6 commits into from
Feb 26, 2024

Conversation

Data-Nexus
Copy link
Contributor

Fixes:

  • Updated graph-ts and cli & AS migrations
  • Updated ERC20 ABI to allow larger decimals and add a less than 255 check in fetchTokenDecimals()
  • Updated MIN_ETH_LOCKED to 300 BNB to fix TVL issues
  • Updated reference pool to 0x6fe9e9de56356f7edbfcbb29fab7cd69471a4869 since the currently reference pool only has 6k TVL
  • Rewound graft block to handle recent TVL issues

@socket-security Socket Security
Copy link

socket-security bot commented Feb 5, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@graphprotocol/graph-cli@0.64.1 Transitive: environment, eval, filesystem, network, shell, unsafe +488 143 MB dotansimha
npm/@graphprotocol/graph-ts@0.32.0 Transitive: eval +3 19.2 MB dotansimha
npm/@types/qs@6.9.11 None 0 6.39 kB types
npm/ansi-colors@4.1.3 environment 0 26.1 kB jonschlinkert
npm/apisauce@2.1.6 Transitive: environment, network +2 432 kB infinitered-owner
npm/assemblyscript@0.19.23 eval Transitive: filesystem +5 20.9 MB assemblyscript
npm/async@3.2.5 None 0 808 kB aearly
npm/binaryen@101.0.0-nightly.20210723 None 0 12.5 MB assemblyscript
npm/bn.js@5.2.1 None 0 99 kB fanatid
npm/chownr@2.0.0 filesystem 0 5.75 kB isaacs
npm/cli-table3@0.6.0 Transitive: environment +7 158 kB turbo87
npm/cosmiconfig@7.0.1 filesystem Transitive: environment, unsafe +19 665 kB davidtheclark
npm/debug@4.3.4 environment +1 49.2 kB qix
npm/docker-compose@0.23.19 shell Transitive: environment +1 516 kB alexzeitler
npm/ejs@3.1.9 eval, filesystem Transitive: environment, shell +8 1.24 MB mde
npm/enquirer@2.3.6 environment +1 224 kB jonschlinkert
npm/err-code@3.0.1 None 0 7.76 kB achingbrain
npm/execa@5.1.1 environment, shell Transitive: filesystem +14 187 kB sindresorhus
npm/fs-jetpack@4.3.1 filesystem Transitive: environment +11 235 kB szwacz
npm/get-stream@6.0.1 None 0 12.2 kB sindresorhus
npm/glob@9.3.5 Transitive: environment, filesystem +8 2.23 MB isaacs
npm/gluegun@5.1.2 filesystem, shell Transitive: environment, eval, network, unsafe +100 4.16 MB infinitered-owner
npm/human-signals@2.1.0 None 0 44.3 kB ehmicky
npm/immutable@4.2.1 None 0 676 kB leebyron
npm/ipfs-http-client@55.0.0 network Transitive: environment, filesystem +82 20.4 MB achingbrain
npm/ipfs-utils@9.0.14 Transitive: environment, filesystem, network +35 1.25 MB npm-service-account-ipfs
npm/iso-url@1.2.1 None 0 13.5 kB hugomrdias
npm/jayson@4.0.0 network Transitive: filesystem, shell +11 1.92 MB tedeh
npm/ky@1.2.0 None 0 144 kB sindresorhus
npm/multiaddr@10.0.1 Transitive: environment, network +15 1.4 MB vascosantos
npm/node-fetch@2.7.0 network +3 560 kB node-fetch-bot
npm/ora@4.0.2 Transitive: environment +13 123 kB sindresorhus
npm/picomatch@2.3.1 None 0 90 kB mrmlnc
npm/semver@7.4.0 None +2 120 kB npm-cli-ops
npm/signal-exit@3.0.7 None 0 9.96 kB isaacs
npm/source-map-support@0.5.21 filesystem +2 895 kB linusu
npm/split2@2.2.0 Transitive: environment +10 204 kB matteo.collina
npm/string-width@4.2.3 None +4 68 kB sindresorhus
npm/strip-ansi@6.0.1 None +1 9.64 kB sindresorhus
npm/through2@2.0.5 Transitive: environment +9 191 kB rvagg
npm/yargs-parser@21.1.1 environment, filesystem 0 128 kB oss-bot

🚮 Removed packages: npm/@graphprotocol/graph-cli@0.20.1, npm/@graphprotocol/graph-ts@0.20.1, npm/debug@4.3.1, npm/picomatch@2.2.3

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Feb 5, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/protobufjs@6.11.4
  • Install script: postinstall
  • Source: node scripts/postinstall
Native code npm/secp256k1@4.0.3
Native code npm/keccak@3.0.4
Deprecated npm/multiaddr-to-uri@8.0.0
  • Reason: This module is deprecated, please upgrade to @multiformats/multiaddr-to-uri
Deprecated npm/ipfs-core-types@0.9.0
Deprecated npm/ipfs-core-utils@0.13.0

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/protobufjs@6.11.4
  • @SocketSecurity ignore npm/secp256k1@4.0.3
  • @SocketSecurity ignore npm/keccak@3.0.4
  • @SocketSecurity ignore npm/multiaddr-to-uri@8.0.0
  • @SocketSecurity ignore npm/ipfs-core-types@0.9.0
  • @SocketSecurity ignore npm/ipfs-core-utils@0.13.0

@Data-Nexus
Copy link
Contributor Author

Builds to: QmNtvKgPtgHS8vrx5RvXz1SK6ERVwNQrLQNRthz8q25Bt2
Link for testing: https://thegraph.com/hosted-service/subgraph/graph-buildersdao/univ3-bsc?version=pending

@ianlapham ianlapham merged commit b31edef into Uniswap:bsc Feb 26, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Data-Nexus @ianlapham