Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with namespace when logs command run before start #5789

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

bawjensen
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5788
License MIT
Doc PR

I created the ticket linked above, and this is my attempt at a fix.

This implementation is something my company has been using (via pnpm patch) for a few months now to good effect. Others might benefit from it too.

I tried to do something similar to what I did in my past PR (#5660), since that one seemed rather painless.

@bawjensen
Copy link
Contributor Author

I tried to do something similar to what I did in my past PR (#5660), since that one seemed rather painless.

perhaps worth noting: this fix works by deleting code. That's only possible because of the specifics of the change in #5660, i.e. my last pm2 contribution. I opted to split them up, and this second half took me honestly too long to create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant