Internal/2021.3/staging #8079
Merged
Internal/2021.3/staging #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor style guide and link fixes Backport Accessible Language update to replace "see" with "refer to"
Backports DOCG-1014 work to 2021.3 URP Docs
Backports for fixes URP Docs table formatting to 2021.3
Backport Rendering Debugger Docs Changes to 2021.3 Docs
…d when comming back from a Maximized state The `OnDisable` is called just after the on Enable when coming back from a Maximized state. Making events unsubscribed.
…RP for Editor FinalCopyDepth pass Backport of #48821 Fixed UUM-57147
|
It appears that you made a non-draft PR! |
https://jira.unity3d.com/browse/UUM-71171 The meta pass of the default HDRP terrain shader (TerrainLit.shader) is currently broken. It always outputs black albedo, resulting in no bounced lighting whatsoever. This was a regression introduced in this PR https://github.cds.internal.unity3d.com/unity/unity/pull/20840, which moved around some shader includes, but neglected to update the Terrain shader according. The bug is essentially that the meta pass is incorrectly using camera-relative rendering. This fix is to restore the missing include in the terrain shader.
…-72286) Fixes UUM-72286. The issue is that the backport done in #24502 accidentally changed two components in the offset vectors sent for Additional Light Shadows.
Fix minor URP documentation issues from feedback tickets. - https://jira.unity3d.com/browse/DOCG-5000 - https://jira.unity3d.com/browse/DOCG-5323 - https://jira.unity3d.com/browse/DOCG-5643 - https://jira.unity3d.com/browse/DOCG-5660 - https://jira.unity3d.com/browse/DOCG-5662 - https://jira.unity3d.com/browse/DOCG-5759 Jira ticket:
Backport https://github.cds.internal.unity3d.com/unity/unity/pull/50033. Also updates test frameworks and tool to latest.
https://forum.unity.com/threads/any-idea-why-decals-turn-to-red-in-2021-3.1371561/ Repro seems to be something like: create a project with an old version of hdrp and create a decal material with for example affect emissive disabled close the project, and reopen it with the latest HDRP version you should have the popup telling you materials need to be upgraded, click yes and wait after the upgrade, the decal material should have emissive enabled until you open the material in the inspector This is due to HDRP not being fully initialized yet when the material auto upgrade kicks in, so the correct subshader is not used when checking for enabled passes Fix consists on not doing anything if we detect we are in this case. This may cause an issue later if we have an upgrade step that relies on reading the passes but since it's not the case currently it should work fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.