Various bugfix from Gabe #571
Open
+64
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modrimkus-unity
requested changes
Oct 10, 2024
Comment on lines
+12
to
+14
| - [STO-3427] Fixing a bug where Polyshape creation tool was not working with orthographic camera. | ||
| - [STO-3429] Fixing a bug where increment snapping was ignored when drawing ProBuilder shapes. | ||
| - [STO-3432] Fixing a bug where Polyshape creation tool was not placing properly the first point on a custom grids. |
There was a problem hiding this comment.
Suggested change
| - [STO-3427] Fixing a bug where Polyshape creation tool was not working with orthographic camera. | |
| - [STO-3429] Fixing a bug where increment snapping was ignored when drawing ProBuilder shapes. | |
| - [STO-3432] Fixing a bug where Polyshape creation tool was not placing properly the first point on a custom grids. | |
| - [STO-3427] Fixed a bug where Polyshape creation tool was not working with orthographic camera. | |
| - [STO-3429] Fixed a bug where increment snapping was ignored when drawing ProBuilder shapes. | |
| - [STO-3432] Fixed a bug where Polyshape creation tool was not placing properly the first point on a custom grids. |
| @@ -472,6 +470,16 @@ void OnOverlayGUI(UObject target, SceneView view) | |||
| EditorGUILayout.EndVertical(); | |||
| } | |||
|
|
|||
| internal void SetShapeHeight() | |||
| { | |||
| UndoUtility.RecordObject(polygon, "Set Height"); | |||
There was a problem hiding this comment.
Did some manual testing around Undo (as Undo was touched) and seems there's issues:
Screen.Recording.2024-10-10.at.4.51.47.PM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixed
[STO-3427] Fixing a bug where Polyshape creation tool was not working with orthographic camera.
[STO-3429] Fixing a bug where increment snapping was ignored when drawing ProBuilder shapes.
[STO-3432] Fixing a bug where Polyshape creation tool was not placing properly the first point on a custom grids.
Links
Jira:
Comments to Reviewers
[List known issues, planned work, provide any extra context for your code.]