Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

update dependencies to newer versions for sprawl compatibility #146

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

zook-unity
Copy link

Peer Review Information

upgraded google-cloud-storage to >=1.31.1 and numpy to >=1.18.2

Pull Request Check List

no new tests or documentation.

@zook-unity zook-unity changed the base branch from master to 0.2.x February 18, 2021 22:49
@zook-unity zook-unity requested a review from adason February 18, 2021 23:45
@zook-unity
Copy link
Author

one note: i have not done any additional testing for cloud training and storage, &c.

pyproject.toml Outdated
@@ -26,10 +26,10 @@ include = [
[tool.poetry.dependencies]
python = "^3.7"
cython = "^0.29.14"
google-cloud-storage = ">=1.24.1 <=1.28.1"
google-cloud-storage = ">=1.31.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this issue was fixed in `google-cloud-storage 1.31+?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did not know about that issue. it looks like 1.31.1 merged those changes. we could do a later version if that matters, but i picked this to align with what sprawl uses currently

release notes for the fix: https://github.com/googleapis/python-storage/releases/tag/v1.31.1
blob: base64 includes additional characters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know the issue is fixed. Let's also include <2.0.0 in the requirements to make sure we don't accidentally bump the major version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. anything look off?

pyproject.toml Outdated
jupyter = "^1.0.0"
kornia = "^0.1.4"
numpy = ">=1.17 < 1.18"
numpy = ">=1.18.2"
Copy link
Contributor

@adason adason Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use ^1.18.2 or >=1.18.2 <2.0.0 (they are equivalent syntex). This prevents unexpected major version bump.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good call! making that update.

@zook-unity zook-unity requested a review from adason February 20, 2021 00:22
@zook-unity zook-unity merged commit 022fd4c into 0.2.x Feb 24, 2021
@zook-unity zook-unity deleted the 0.2.x-dependency-update branch February 24, 2021 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants