Skip to content

Commit

Permalink
Generate perfmap files, not jitdump files
Browse files Browse the repository at this point in the history
  • Loading branch information
vvuk committed May 29, 2024
1 parent d346779 commit 4e612cd
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions RELEASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

## Unreleased - ReleaseDate

## 0.12.7 - 2024-05-28 - Unity release

### Features

- For `--coreclr` on mac, set `DOTNET_PerfMapEnabled=3` instead of 2, to only produce much smaller perfmap files instead of jitdump files. If full jit assembly is needed, the environment variable can be set manually.

## 0.12.6 - 2024-05-23 - Unity release

### Features
Expand Down
2 changes: 1 addition & 1 deletion samply/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "usamply"
version = "0.12.6"
version = "0.12.7"
authors = ["Markus Stange <mstange@themasta.com>", "Vladimir Vukicevic <vladimir@pobox.com>"]
edition = "2021"
rust-version = "1.74" # needed by clap and wholesym
Expand Down
4 changes: 2 additions & 2 deletions samply/src/mac/profiler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ pub fn start_recording(
} = process_launch_props;

if profile_creation_props.coreclr.any_enabled() {
// We need to set DOTNET_PerfMapEnabled=2 in the environment if it's not already set.
// We need to set DOTNET_PerfMapEnabled=3 in the environment if it's not already set.
// If we set it, we'll also set unlink_aux_files=true to avoid leaving files
// behind in the temp directory. But if it's set manually, assume the user
// knows what they're doing and will specify the arg as needed.
if !env_vars.iter().any(|p| p.0 == "DOTNET_PerfMapEnabled") {
env_vars.push(("DOTNET_PerfMapEnabled".into(), "2".into()));
env_vars.push(("DOTNET_PerfMapEnabled".into(), "3".into()));
unlink_aux_files = true;
}
}
Expand Down

0 comments on commit 4e612cd

Please sign in to comment.