Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openreferences=missing count #140

Merged
merged 24 commits into from
Mar 20, 2022
Merged

Conversation

Universal-Omega
Copy link
Owner

@Universal-Omega Universal-Omega commented Mar 20, 2022

This converts openreferences=missing to initially query only missing articles from the pagelinks table. Previously it didn't query, just filtered output, which makes the count parameter still count all results, even ones not displayed on-page.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #140 (54d756b) into master (b75487b) will increase coverage by 0.28%.
The diff coverage is 78.57%.

@@             Coverage Diff             @@
##             master    #140      +/-   ##
===========================================
+ Coverage      8.06%   8.35%   +0.28%     
+ Complexity     1560    1559       -1     
===========================================
  Files            22      22              
  Lines          4327    4333       +6     
===========================================
+ Hits            349     362      +13     
+ Misses         3978    3971       -7     
Impacted Files Coverage Δ
includes/Parse.php 0.00% <0.00%> (ø)
includes/Query.php 38.79% <84.61%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75487b...54d756b. Read the comment docs.

@Universal-Omega Universal-Omega changed the title Fix openreferences=missing Fix openreferences=missing count Mar 20, 2022
@Universal-Omega Universal-Omega merged commit d5b3539 into master Mar 20, 2022
@Universal-Omega Universal-Omega deleted the Universal-Omega-patch-2 branch March 20, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openreferences=missing counts and substracts
2 participants