Support MediaWiki 1.39 for actor and templatelinks migration #188

Universal-Omega · 2022-06-23T18:21:34Z

This adds support for 1.39, and drops support for older versions, since 1.39 is the current LTS release.

codecov-commenter · 2022-06-23T20:03:11Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.58537% with 78 lines in your changes missing coverage. Please review.

Project coverage is 8.59%. Comparing base (bd6e23d) to head (25f9eae).
Report is 93 commits behind head on master.

Files with missing lines	Patch %	Lines
includes/Query.php	54.21%	38 Missing ⚠️
includes/Parse.php	0.00%	16 Missing ⚠️
includes/UpdateArticle.php	0.00%	10 Missing ⚠️
includes/Article.php	0.00%	6 Missing ⚠️
includes/LST.php	0.00%	5 Missing ⚠️
maintenance/createTemplate.php	0.00%	2 Missing ⚠️
includes/Hooks.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             master    #188      +/-   ##
===========================================
+ Coverage      5.99%   8.59%   +2.60%     
- Complexity     1565    1568       +3     
===========================================
  Files            23      23              
  Lines          4357    3839     -518     
===========================================
+ Hits            261     330      +69     
+ Misses         4096    3509     -587

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md

@@ -787,3 +787,9 @@
 * Updated CreateTemplate to mention DPL3, not DPL
 * Used database update maintenance script for creating VIEW
 * Added additional isset check for mTemplatePath
+
+# Version 3.4.7
+* Dropped `revision_actor_temp` support and completed actor migration


Check commit and GitHub actions for more details

includes/Parse.php


 			return $this->getFullOutput();
 		}

 		// Check if DPL shall only be executed from protected pages.
-		if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && !$parser->getTitle()->isProtected( 'edit' ) ) {
+		if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && !$parser->getPage()->isProtected( 'edit' ) ) {


includes/Parse.php

@@ -405,7 +405,7 @@
 			}

 			$title = Title::makeTitle( $pageNamespace, $pageTitle );
-			$thisTitle = $parser->getTitle();
+			$thisTitle = Title::castFromPageReference( $parser->getPage() );


includes/Parse.php

 	 */
 	public function parse( $input, Parser $parser, &$reset, &$eliminate, $isParserTag = false ) {
 		$dplStartTime = microtime( true );

 		// Reset headings when being ran more than once in the same page load.
 		Article::resetHeadings();

+		$title = Title::castFromPageReference( $parser->getPage() );


includes/Parse.php


 			return $this->getFullOutput();
 		}

 		// Check if DPL shall only be executed from protected pages.
-		if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && !$parser->getTitle()->isProtected( 'edit' ) ) {
+		if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && !$title->isProtected( 'edit' ) ) {


includes/LST.php

@@ -124,7 +120,8 @@
 				return $text;
 			}
 		} else {
-			return "[[" . $parser->getTitle()->getPrefixedText() . "]]" . "<!-- WARNING: LST loop detected -->";
+			$title = Title::castFromPageReference( $parser->getPage() );


includes/Parse.php

 		// Check if DPL shall only be executed from protected pages.
-		if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && !$parser->getTitle()->isProtected( 'edit' ) ) {
+		if ( Config::getSetting( 'runFromProtectedPagesOnly' ) === true && $title && !$restrictionStore->isProtected( $title, 'edit' ) ) {


includes/Query.php

Co-authored-by: pandafox <allen@freedom.tm>

CHANGELOG.md

@@ -787,3 +787,19 @@
 * Updated CreateTemplate to mention DPL3, not DPL
 * Used database update maintenance script for creating VIEW
 * Added additional isset check for mTemplatePath
+
+# Version 3.5.0


CHANGELOG.md

@@ -787,3 +787,19 @@
 * Updated CreateTemplate to mention DPL3, not DPL
 * Used database update maintenance script for creating VIEW
 * Added additional isset check for mTemplatePath
+
+# Version 3.5.0


CHANGELOG.md

+* Replaced usage of deprecated `Title::isProtected()`
+* Replaced usage of deprecated `User::matchEditToken()`
+* Replaced usage of deprecated `Article::doDelete()`
+* Added `null` checks on `Parser::getPage()` and `ParserOutput` before using to avoid fatals


Universal-Omega changed the title ~~Drop revision_actor_temp support~~ Drop revision_actor_temp and <MediaWiki 1.38.0 support Jun 23, 2022

Universal-Omega changed the title ~~Drop revision_actor_temp and <MediaWiki 1.38.0 support~~ Drop revision_actor_temp and < MediaWiki 1.38.0 support Jun 23, 2022

Universal-Omega changed the title ~~Drop revision_actor_temp and < MediaWiki 1.38.0 support~~ Drop revision_actor_temp and < MediaWiki 1.38.0 support; and support MediaWiki 1.39+ Jun 23, 2022

Universal-Omega changed the title ~~Drop revision_actor_temp and < MediaWiki 1.38.0 support; and support MediaWiki 1.39+~~ Drop revision_actor_temp and < MediaWiki 1.38.0 support; and support MediaWiki 1.39 Jun 23, 2022

Universal-Omega marked this pull request as draft June 23, 2022 21:00

Universal-Omega force-pushed the revision branch 3 times, most recently from c1f5cbf to 7d4b063 Compare June 28, 2022 17:10

Universal-Omega force-pushed the revision branch 2 times, most recently from 9de7eb9 to 382ce35 Compare July 13, 2022 15:18

github-advanced-security bot found potential problems Jul 13, 2022

View reviewed changes

Universal-Omega force-pushed the revision branch from 150ca76 to 05190aa Compare July 17, 2022 15:45

Universal-Omega and others added 17 commits July 29, 2022 17:21

Drop revision_actor_temp support

b37032d

Update extension.json

eaac61d

Update mediawiki-tests.yml

f109597

Update Query.php

4aaff17

Update seed-data.xml

afb2802

Update DPLIntegrationTestCase.php

b22ac2e

Update createTemplate.php

af09941

Update UpdateArticle.php

6ca66ef

CI: lint code to MediaWiki standards

40f57a5

Check commit and GitHub actions for more details

Update Article.php

5146acb

Update seed-data.xml

3baac2d

Update seed-data.xml

b1d6f8c

Update DPLIntegrationTestCase.php

f7a98c1

Update DPLIntegrationTestCase.php

c1d1032

Update DPLQueryIntegrationTest.php

98e6845

Update DPLIntegrationTestCase.php

3ea48ab

Update DPLQueryIntegrationTest.php

e09b77e

Universal-Omega added 2 commits October 13, 2022 10:15

Update LST.php

6a6b046

Update Hooks.php

8dfa04a

github-advanced-security bot found potential problems Oct 13, 2022

View reviewed changes

Universal-Omega added 3 commits October 13, 2022 10:27

Update Parse.php

68908c0

Update LST.php

62c0077

Update LST.php

a285e13

github-advanced-security bot found potential problems Oct 13, 2022

View reviewed changes

Universal-Omega added 2 commits October 13, 2022 10:39

Update Parse.php

870455b

Update Parse.php

6368e2e

github-advanced-security bot found potential problems Oct 13, 2022

View reviewed changes

Universal-Omega added 9 commits October 13, 2022 10:50

Update Parse.php

f28f86c

Update UpdateArticle.php

c6c0a2c

Update Query.php

e607a4b

Update mediawiki-tests.yml

36acf71

Update mediawiki-tests.yml

c82d5a7

Update seed-data.xml

f10d20e

Merge branch 'master' into revision

c607bf4

replace intval() with (int)

9e6066f

Update CHANGELOG.md

353d6ae

pandafox reviewed Nov 25, 2022

View reviewed changes

includes/Query.php Outdated Show resolved Hide resolved

Universal-Omega and others added 2 commits December 6, 2022 16:16

Update includes/Query.php

0dece73

Co-authored-by: pandafox <allen@freedom.tm>

Merge branch 'master' into revision

7d13f5f

Universal-Omega marked this pull request as ready for review December 6, 2022 23:16

Universal-Omega added 3 commits December 6, 2022 16:30

Update CHANGELOG.md

59e1db3

Update CHANGELOG.md

002c616

Update extension.json

25f9eae

github-advanced-security bot found potential problems Dec 6, 2022

View reviewed changes

Universal-Omega merged commit 8dd8d03 into master Dec 7, 2022

Universal-Omega deleted the revision branch December 7, 2022 00:10

Universal-Omega restored the revision branch December 7, 2022 00:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support MediaWiki 1.39 for actor and templatelinks migration #188

Support MediaWiki 1.39 for actor and templatelinks migration #188

Universal-Omega commented Jun 23, 2022 •

edited

Loading

codecov-commenter commented Jun 23, 2022 •

edited

Loading

Support MediaWiki 1.39 for actor and templatelinks migration #188

Support MediaWiki 1.39 for actor and templatelinks migration #188

Conversation

Universal-Omega commented Jun 23, 2022 • edited Loading

codecov-commenter commented Jun 23, 2022 • edited Loading

Codecov Report

Universal-Omega commented Jun 23, 2022 •

edited

Loading

codecov-commenter commented Jun 23, 2022 •

edited

Loading