Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for links migration: add JOIN on linktarget for notuses #213

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

Universal-Omega
Copy link
Owner

@Universal-Omega Universal-Omega commented Jan 4, 2023

Also adds a PHPUnit tests for the notuses parameter.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #213 (9dcfd1d) into master (8dd8d03) will increase coverage by 2.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage      8.59%   10.71%   +2.11%     
  Complexity     1568     1568              
============================================
  Files            23       23              
  Lines          3839     4257     +418     
============================================
+ Hits            330      456     +126     
- Misses         3509     3801     +292     
Impacted Files Coverage Δ
includes/Query.php 39.54% <100.00%> (-0.55%) ⬇️
includes/LST.php 0.00% <0.00%> (ø)
includes/Hooks.php 0.00% <0.00%> (ø)
includes/Parse.php 0.00% <0.00%> (ø)
includes/Variables.php 0.00% <0.00%> (ø)
includes/Parameters.php 0.00% <0.00%> (ø)
includes/Lister/Lister.php 0.00% <0.00%> (ø)
includes/UpdateArticle.php 0.00% <0.00%> (ø)
includes/ParametersData.php 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -803,3 +803,6 @@
* Replaced usage of deprecated `User::matchEditToken()`
* Replaced usage of deprecated `Article::doDelete()`
* Added `null` checks on `Parser::getPage()` and `ParserOutput` before using to avoid fatals

# Version 3.5.1
* Added a fix for links migration: added a `JOIN` on `linktarget` for the `notuses` parameter

Check warning

Code scanning / Markdownlint (reported by Codacy)

Lists should be surrounded by blank lines

Lists should be surrounded by blank lines
@@ -803,3 +803,6 @@
* Replaced usage of deprecated `User::matchEditToken()`
* Replaced usage of deprecated `Article::doDelete()`
* Added `null` checks on `Parser::getPage()` and `ParserOutput` before using to avoid fatals

# Version 3.5.1
* Added a fix for links migration: added a `JOIN` on `linktarget` for the `notuses` parameter

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 93

Expected: 80; Actual: 93
@@ -803,3 +803,6 @@
* Replaced usage of deprecated `User::matchEditToken()`
* Replaced usage of deprecated `Article::doDelete()`
* Added `null` checks on `Parser::getPage()` and `ParserOutput` before using to avoid fatals

# Version 3.5.1

Check warning

Code scanning / Markdownlint (reported by Codacy)

Multiple top-level headings in the same document

Multiple top-level headings in the same document
@@ -803,3 +803,6 @@
* Replaced usage of deprecated `User::matchEditToken()`
* Replaced usage of deprecated `Article::doDelete()`
* Added `null` checks on `Parser::getPage()` and `ParserOutput` before using to avoid fatals

# Version 3.5.1

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 1; Actual: 0; Below

Expected: 1; Actual: 0; Below
@Universal-Omega Universal-Omega changed the title Fix for links migration: add JOIN on linktarget Fix for links migration: add JOIN on linktarget for notuses Jan 4, 2023
@Universal-Omega Universal-Omega merged commit d7336b1 into master Jan 4, 2023
@Universal-Omega Universal-Omega deleted the Universal-Omega-patch-1 branch January 4, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants