Fix passing launch_dashobard_client launch argument #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urrsk
approved these changes
Jul 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument (cherry picked from commit ca19535) # Conflicts: # ur_robot_driver/launch/ur_control.launch.py # ur_robot_driver/test/test_common.py
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument (cherry picked from commit ca19535) # Conflicts: # ur_robot_driver/launch/ur_control.launch.py # ur_robot_driver/test/test_common.py
1 task
fmauch
added a commit
that referenced
this pull request
Jul 26, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument (cherry picked from commit ca19535) # Conflicts: # ur_robot_driver/launch/ur_control.launch.py # ur_robot_driver/test/test_common.py
fmauch
added a commit
that referenced
this pull request
Jul 26, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument (cherry picked from commit ca19535)
fmauch
added a commit
that referenced
this pull request
Jul 26, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument (cherry picked from commit ca19535)
fmauch
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument
fmauch
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Fix passing launch_dashobard_client launch argument This was not handled properly * Do start dashboard_client in driver_test * Add test for checking launch_dashboard_client argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not handled properly.
This fixes #1056
ToDo: