Fix for forward_velocity_controller test #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
force-pushed
the
test_forward_velocity_controller
branch
from
295e274 to
ac1cea3
Compare
fmauch
approved these changes
Sep 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Update config with correct parameters and names * Changed name for better description of the file (cherry picked from commit b422d49) # Conflicts: # ur_robot_driver/launch/test_forward_velocity_controller.launch.py
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Update config with correct parameters and names * Changed name for better description of the file (cherry picked from commit b422d49)
fmauch
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Update config with correct parameters and names * Changed name for better description of the file Co-authored-by: Vincenzo Di Pentima <DiPentima@fzi.de>
URJala
pushed a commit
to URJala/Universal_Robots_ROS2_Driver
that referenced
this pull request
Dec 20, 2024
* Update config with correct parameters and names * Changed name for better description of the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the test for the
forward_velocity_controller: basically the related config file was missing thepublish_topicparameter. Now when the controller is active, the velocity goals are correctly sent by launchingtest_forward_velocity_controller.launch.py.