Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the analog output domain when setting an analog output #1123

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Oct 8, 2024

This basically implements a service for ros-industrial/ur_msgs#30

Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended and looks good to me.

@VinDp VinDp merged commit 8f2dfa9 into UniversalRobots:main Oct 8, 2024
6 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Oct 8, 2024
(cherry picked from commit 8f2dfa9)

# Conflicts:
#	ur_controllers/doc/index.rst
#	ur_robot_driver/urdf/ur.ros2_control.xacro
mergify bot pushed a commit that referenced this pull request Oct 8, 2024
(cherry picked from commit 8f2dfa9)

# Conflicts:
#	ur_controllers/doc/index.rst
#	ur_robot_driver/urdf/ur.ros2_control.xacro
@fmauch fmauch deleted the analog_domain branch October 8, 2024 19:21
fmauch added a commit that referenced this pull request Oct 26, 2024
(cherry picked from commit 8f2dfa9)

# Conflicts:
#	ur_controllers/doc/index.rst
#	ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch added a commit that referenced this pull request Oct 26, 2024
(cherry picked from commit 8f2dfa9)

# Conflicts:
#	ur_controllers/doc/index.rst
#	ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch added a commit that referenced this pull request Oct 28, 2024
(cherry picked from commit 8f2dfa9)

# Conflicts:
#	ur_controllers/doc/index.rst
#	ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch added a commit that referenced this pull request Oct 28, 2024
(cherry picked from commit 8f2dfa9)

# Conflicts:
#	ur_controllers/doc/index.rst
#	ur_robot_driver/urdf/ur.ros2_control.xacro
fmauch pushed a commit that referenced this pull request Oct 28, 2024
fmauch pushed a commit that referenced this pull request Oct 28, 2024
URJala pushed a commit to URJala/Universal_Robots_ROS2_Driver that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants