-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added service to control force mode from ROS2 #579
Conversation
Since I did some amount of work on this, I think this should be reviewed by @RobertWilbrandt. In a nutshell I think it is very discussable whether we add this functionality to the IO controller or whether we should shift it to another controller. As we put a lot of stuff into the IO controller, I don't see why this should not go into this, as well, but I definitively don;t like getting this thing bigger and bigger. Also, tests would be good, but that would also go for the other components inside that controller. |
Thinking about this: I really think, this should go into its own controller. Then activating / deactivating the controller would be activating / deactivating force_mode providing a service for parametrizing the force_mode. Also, setting force_mode's damping and gain should be handled from this. |
Closing this in favor of #1049 |
Added service to set force mode
Needs ros-industrial/ur_msgs#21 and UniversalRobots/Universal_Robots_ROS2_Description#75
ToDo list