Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service to control force mode from ROS2 #579

Closed
wants to merge 6 commits into from

Conversation

urmarp
Copy link
Contributor

@urmarp urmarp commented Jan 9, 2023

Added service to set force mode

Needs ros-industrial/ur_msgs#21 and UniversalRobots/Universal_Robots_ROS2_Description#75

ToDo list

  • Make force_mode work
  • Implement an own controller for force_mode
  • Document force_mode_controller
  • Make controller thread_safe using realtime_buffer
  • Test and probably improve force_mode_controller in conjunction with moving the robot
  • Add test(s) for force_mode_controller

@fmauch fmauch requested a review from RobertWilbrandt June 28, 2023 20:38
@fmauch
Copy link
Collaborator

fmauch commented Jun 28, 2023

Since I did some amount of work on this, I think this should be reviewed by @RobertWilbrandt.

In a nutshell I think it is very discussable whether we add this functionality to the IO controller or whether we should shift it to another controller. As we put a lot of stuff into the IO controller, I don't see why this should not go into this, as well, but I definitively don;t like getting this thing bigger and bigger.

Also, tests would be good, but that would also go for the other components inside that controller.

@fmauch
Copy link
Collaborator

fmauch commented Jun 29, 2023

Thinking about this: I really think, this should go into its own controller. Then activating / deactivating the controller would be activating / deactivating force_mode providing a service for parametrizing the force_mode.

Also, setting force_mode's damping and gain should be handled from this.

@fmauch fmauch self-assigned this Jun 30, 2023
@urrsk urrsk changed the title Added service to set force mode Added service to control force mode Aug 4, 2023
@urrsk urrsk changed the title Added service to control force mode Added service to control force mode from ROS Aug 4, 2023
@urrsk urrsk changed the title Added service to control force mode from ROS Added service to control force mode from ROS2 Dec 20, 2023
@fmauch fmauch assigned VinDp and unassigned fmauch Jul 1, 2024
@URJala URJala mentioned this pull request Jul 8, 2024
@fmauch
Copy link
Collaborator

fmauch commented Jul 16, 2024

Closing this in favor of #1049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants