Reduce number of controller_spawners to 3 #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the controller_spawner supports a list of controllers since a while we can use this to reduce the number of total controllers.
|
I wrapped my head around trying to merge the trajectory controller spawner either with the active spawner or the inactive spawner, by adding it to the respective list during runtime, but I was not successful... Maybe we can leave this to a later PR. |
1 task
VinDp
approved these changes
Feb 12, 2024
This was referenced Feb 12, 2024
fmauch
added a commit
that referenced
this pull request
Apr 15, 2024
* Reduce number of controller_spawners to 3 Since the controller_spawner supports a list of controllers since a while we can use this to reduce the number of total controllers. (cherry picked from commit 31993ab) * Reverted unrelated changes --------- Co-authored-by: Felix Exner <exner@fzi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the controller_spawner supports a list of controllers since a while we can use this to reduce the number of total controllers.
This should help improving on #869. This is not a fix of the originating problem, but it could definitively improve our situation in the meantime.