Adjust pdfjs-dist to reflect actual version being used via CDN. #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
requested changes
Sep 2, 2024
package.json
Outdated
| @@ -113,7 +113,7 @@ | |||
| "mediaelement": "4.2.15", | |||
| "mediaelement-plugins": "2.5.1", | |||
| "openseadragon": "2.4.2", | |||
| "pdfjs-dist": "4.6.82", | |||
| "pdfjs-dist": "2.0.161", | |||
There was a problem hiding this comment.
Do you think it's worth changing this to 3.11.174 while we're changing it again anyway, so it at least reflects the version that is actually being used? That way, if we get any security alerts, we'll actually know they're for real. :-)
demiankatz
changed the title
demiankatz
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks, @Saira-A -- I've renamed the PR to reflect what's actually happening here now, and will merge it.
demiankatz
deleted the
revert-1098-dependabot/npm_and_yarn/dev/pdfjs-dist-4.6.82
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1098