Fix colors in console reporter, resolves #298 #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
reviewed
May 19, 2023
| @@ -709,7 +709,9 @@ ok, fail, skipped, infoOk, infoFail :: (?colors :: Bool) => String -> IO () | |||
| fail = output failFormat | |||
| ok = output okFormat | |||
| skipped = output skippedFormat | |||
| infoOk = output infoOkFormat | |||
| -- Just default foreground color for 'infoOk'; do not apply 'infoOkFormat', | |||
| -- because terminal's background could be white itself. See #298. | |||
There was a problem hiding this comment.
Yeah, that is the usual problem with coloring output.
We have the same problem when considering coloring errors for Agda.
It would be great to have symbolic colors, that resolve to physical color according to some (standard or custom) coloring scheme, depending on the background color.
I haven't found any Haskell solution to that problem yet (that at least works well on modern terminals).
There was a problem hiding this comment.
Yeah, I'm not aware of any fundamental solution. Other colors used by tasty are less problematic: it's highly unlikely that someone has a terminal with red or green background; it's only infoOkFormat who poses an issue.
andreasabel
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to be clever, just
putStr:)