Improve --hide-successes to not print headings for empty test subtrees #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
approved these changes
Dec 6, 2023
This way console reporter will not need to print group headings when group contains no tests, amoung other things.
sergv
force-pushed
the
improve-hide-successes
branch
from
4c4d899
to
cbab6ba
Compare
|
Updated with different approach: instead of filtering out empty subtrees during printing, don't generate them in the first place in the |
|
@martijnbastiaan could you possibly review this? I think it touches parts of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve --hide-successes to not print headings for empty test subtrees (i.e. when -p filtered tests out).
This is again inspired by Emacs which cannot deal with escape sequence that moves cursor up one line. This change makes those movement unneeded since heading is not printed if there are no tests under it.
Should benefit everyone though since there's no point in printing only to delete afterwards, even if one wants to see progress - there's no progress being made in those empty subtrees that were filtered out.