Don't Clone Context in UnleashContext.ApplyStaticFields #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling
IUnleash.IsEnabled
we end up cloning theUnleashContext
. This cloning is not needed and expensive since the entireProperties
dictionary needs to be cloned. This case removes the cloning.Fixes #186
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Using the following benchmark (note
IsEnabled2
calls the code proposed in this PR):The following results were obtained:
Empty Properties
10 Elements in Properties