Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make semver logging actually log context value that failed parsing #200

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

sighphyre
Copy link
Member

This patches the logging in the semver constraint to actually take the parameter that it needs to log, rather than throwing around a format string with nothing to format into it. This would previously cause some log implementations to crash and others to log a very unhelpful error message.

… parse rather than allowing the logger to potentially crash
@sighphyre sighphyre requested a review from daveleek January 19, 2024 10:35
Copy link
Collaborator

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that should improve things

@sighphyre sighphyre merged commit 649cdbb into main Jan 19, 2024
3 checks passed
@sighphyre sighphyre deleted the fix/semver-constraint-logging branch January 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants