Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary else branch in date constraint #247

Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore: remove unnecessary else branch in date constraint #247

merged 1 commit into from
Oct 25, 2024

Conversation

sighphyre
Copy link
Member

This just removes the else statement code here and makes the if the only code path.

The else is now redundant, based on this PR #246 which forces the context to always have a current time

gastonfournier
gastonfournier approved these changes Oct 25, 2024
View reviewed changes
Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sighphyre sighphyre merged commit 5eb037a into main Oct 25, 2024
3 checks passed
@sighphyre sighphyre deleted the chore/clean-up-date-constraint branch October 25, 2024 09:25
@tlevesque-ueat tlevesque-ueat mentioned this pull request Oct 28, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonfournier gastonfournier gastonfournier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sighphyre @gastonfournier