Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy domain entities and associated tests #251

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented Oct 30, 2024

Trims out the legacy artifacts, tries to make minimal changes to tests to preserve sanity. None of this is needed post Yggdrasil and needs to be removed prior to next major version

There's a bunch of stuff that can be further trimmed but I think I want something like style cop to do that rather than manual. Will tackle in future PR, may or may not be before next major

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sighphyre sighphyre merged commit b3f4938 into main Oct 30, 2024
3 checks passed
@sighphyre sighphyre deleted the chore/cleanup-legacy branch October 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants