feat: allow for listing the flags known to the SDK #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
commented
Oct 31, 2024
| public string Description { get; set; } | ||
| public UnleashContextDefinition Context { get; set; } | ||
| public string ToggleName { get; set; } | ||
| public Variant ExpectedResult |
There was a problem hiding this comment.
This wasn't loading feature enabled correctly. So the spec tests haven't been checking feature_enabled correctly until now
gastonfournier
approved these changes
Oct 31, 2024
| @@ -17,7 +17,7 @@ internal class UnleashServices : IDisposable | |||
| private readonly CancellationTokenSource cancellationTokenSource = new CancellationTokenSource(); | |||
| private readonly IUnleashScheduledTaskManager scheduledTaskManager; | |||
|
|
|||
| public const string supportedSpecVersion = "4.5.1"; | |||
| public const string supportedSpecVersion = "5.1.7"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to list the features known to the SDK. This is intended to replace the legacy option to access the feature flags directly, which is typically used to iterate the known flags and evaluate them all
There's a bunch of noise her moving from
IsEnabledtoEnabledin the engine but that's all internalAlso fixes the client spec header because that's wantonly out of sync at this point