Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send default buckets instead of null metrics buckets as they cause 400s #267

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

daveleek
Copy link
Collaborator

@daveleek daveleek commented Dec 10, 2024

Initializes a metric bucket with default values if the send metrics bucket comes back as null from the engine.
This lets us keep metrics as a heartbeat even when buckets are empty

This does not introduce the 10min hold off that Ruby does. Should it?

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. better than throwing errors.

@daveleek daveleek merged commit 465b2dd into main Dec 10, 2024
9 checks passed
@daveleek daveleek deleted the fix/null-metrics-buckets-cause-400s branch December 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants