feat: strategy variants #482

kwasniew · 2023-07-10T13:29:25Z

About the changes

Adding support for strategy variants.

Background: Unleash supports feature environment variants. This PR adds variants capability per strategy which is more flexible and easier to understand/implement. It makes it possible to use constraints and segments for variants.

How it's implemented?
If a strategy has a corresponding variant param it's used over the feature environment variant.

Important files

Discussion points

I'm thinking if we should have env var or config param to enable this new capability in addition to variant params detection.

coveralls · 2023-07-10T13:30:30Z

coverage: 91.295% (+0.03%) from 91.269% when pulling 2c79ba1 on strategy-variants into b30488f on main.

kwasniew · 2023-07-10T13:36:58Z

src/client.ts

@@ -74,40 +74,56 @@ export default class UnleashClient extends EventEmitter {
    feature: FeatureInterface | undefined,
    context: Context,
    fallback: Function,
-  ): boolean {
+  ): [boolean, VariantDefinition | undefined] {


in addition to boolean true/false was want to know the actual variant that the strategy resolved to if it was provided.

src/client.ts

kwasniew · 2023-07-10T13:38:12Z

src/client.ts

@@ -169,25 +185,33 @@ export default class UnleashClient extends EventEmitter {
    fallbackVariant?: Variant,
  ): Variant {
    const fallback = fallbackVariant || getDefaultVariant();
-    if (
-      typeof feature === 'undefined' ||


this is too early since variants can be on the strategy

Tymek · 2023-07-10T13:51:32Z

Should should bump SDK compatibility in the future? It will allow us to add warnings if you're using old SDKs with new Variants.

unleash-client-node/src/repository/index.ts

Line 13 in b30488f

const SUPPORTED_SPEC_VERSION = '4.2.0';

sighphyre

Okay wow, that's cool, spec tests pass and all!

sighphyre · 2023-07-10T13:55:06Z

Should should bump SDK compatibility in the future? It will allow us to add warnings if you're using old SDKs with new Variants.

unleash-client-node/src/repository/index.ts

Line 13 in b30488f

const SUPPORTED_SPEC_VERSION = '4.2.0';

Yeah! Needs a spec test before we do that though

sighphyre

LGTM

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unleash-client](https://togithub.com/Unleash/unleash-client-node) | [`4.1.0-beta.5` -> `4.1.0`](https://renovatebot.com/diffs/npm/unleash-client/4.1.0-beta.5/4.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/unleash-client/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/unleash-client/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/unleash-client/4.1.0-beta.5/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/unleash-client/4.1.0-beta.5/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-node (unleash-client)</summary> ### [`v4.1.0`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v4.1.0) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v4.1.0-beta.5...v4.1.0) #### What's Changed - feat: strategy variants by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#482 - fix: remove unused segment fields by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#489 - feat: expose config type by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#491 - fix:fetch lib with its deps by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#492 - fix: force get variant is back by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#493 - refactor: strategy variants inside strategy by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#494 - feat: variant on enabled toggle metrics by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#495 - chore(deps): update dependency nock to v13.3.2 by [@renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#488 - chore(deps): update dependency eslint to v8.45.0 by [@renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#490 - chore(deps): update typescript-eslint monorepo to v5.62.0 by [@renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#483 - chore(deps): update dependency eslint-config-airbnb-typescript to v17.1.0 by [@renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#487 - chore(deps): update dependency eslint-plugin-prettier to v5 by [@renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#485 - feat: version bump non beta by [@kwasniew](https://togithub.com/kwasniew) in [Unleash/unleash-client-node#496 **Full Changelog**: Unleash/unleash-client-node@v4.0.2...v4.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

feat: strategy variants

6ea5c3a

fix: linter

d5b605b

kwasniew commented Jul 10, 2023

View reviewed changes

src/client.ts Outdated Show resolved Hide resolved

kwasniew commented Jul 10, 2023

View reviewed changes

src/client.ts Outdated Show resolved Hide resolved

kwasniew commented Jul 10, 2023

View reviewed changes

src/client.ts Outdated Show resolved Hide resolved

kwasniew commented Jul 10, 2023

View reviewed changes

Tymek previously approved these changes Jul 10, 2023

View reviewed changes

sighphyre previously approved these changes Jul 10, 2023

View reviewed changes

fix: handle empty variants

152f33d

kwasniew dismissed stale reviews from sighphyre and Tymek via 152f33d July 10, 2023 14:34

kwasniew mentioned this pull request Jul 11, 2023

Support feature options (strings and json) or complex conditions in getVariant Unleash/unleash#1550

Closed

kwasniew added 2 commits July 12, 2023 08:56

feat: multi variants

8dc2ccc

feat: make overrides optional

f721d1c

kwasniew mentioned this pull request Jul 12, 2023

feat: strategy variant Unleash/client-specification#55

Merged

kwasniew added 2 commits July 12, 2023 16:08

test: specification bump

62bc557

chore: lint

2c79ba1

kwasniew requested review from Tymek and sighphyre July 12, 2023 14:17

sighphyre approved these changes Jul 13, 2023

View reviewed changes

kwasniew merged commit 74705c8 into main Jul 13, 2023
4 checks passed

kwasniew deleted the strategy-variants branch July 13, 2023 08:43

emersonsiega mentioned this pull request Oct 31, 2023

Get payload from Strategy variants Unleash/unleash_proxy_client_flutter#28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: strategy variants #482

feat: strategy variants #482

kwasniew commented Jul 10, 2023 •

edited

Loading

coveralls commented Jul 10, 2023 •

edited by github-actions bot

Loading

kwasniew Jul 10, 2023

kwasniew Jul 10, 2023

Tymek commented Jul 10, 2023

sighphyre left a comment

sighphyre commented Jul 10, 2023

sighphyre left a comment

feat: strategy variants #482

feat: strategy variants #482

Conversation

kwasniew commented Jul 10, 2023 • edited Loading

About the changes

Important files

Discussion points

coveralls commented Jul 10, 2023 • edited by github-actions bot Loading

kwasniew Jul 10, 2023

Choose a reason for hiding this comment

kwasniew Jul 10, 2023

Choose a reason for hiding this comment

Tymek commented Jul 10, 2023

sighphyre left a comment

Choose a reason for hiding this comment

sighphyre commented Jul 10, 2023

sighphyre left a comment

Choose a reason for hiding this comment

kwasniew commented Jul 10, 2023 •

edited

Loading

coveralls commented Jul 10, 2023 •

edited by github-actions bot

Loading