Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dependant toggles #155

Merged
merged 6 commits into from
Oct 16, 2023
Merged

feat: dependant toggles #155

merged 6 commits into from
Oct 16, 2023

Conversation

gardleopard
Copy link
Contributor

This pr implements dependant feature toggles. The tests are specified in the client specifications Unleash/client-specification#63

This pr implements dependant feature toggles. The tests are specified in
the client specifications Unleash/client-specification#63
Copy link

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments

lib/unleash/feature_toggle.rb Outdated Show resolved Hide resolved
lib/unleash/feature_toggle.rb Show resolved Hide resolved
lib/unleash/feature_toggle.rb Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 16, 2023

Pull Request Test Coverage Report for Build 6531319997

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 97.189%

Totals Coverage Status
Change from base Build 6506745562: 0.1%
Covered Lines: 2524
Relevant Lines: 2597

💛 - Coveralls

@gardleopard gardleopard requested a review from sighphyre October 16, 2023 10:02
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to metrics? Parent features shouldn't get metrics incremented. Can we add a test for this?

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G. I realise we want tests for metrics, this is quite tough to do with current structure. Yggdrasil already has those covered. If we want to move to that faster in lieu of tests here that's.... probably okay

@gardleopard
Copy link
Contributor Author

What happens to metrics? Parent features shouldn't get metrics incremented. Can we add a test for this?

We are not touching the path of metrics here. Metrics behaviour is not tested in the sdk at all. If we want to have test for metrics behaviour I vote for having that as a separate PR.

@gardleopard gardleopard merged commit f729378 into main Oct 16, 2023
40 checks passed
@gardleopard gardleopard deleted the dependant_toggles branch October 16, 2023 11:09
@kwasniew
Copy link

@gardleopard the important part is that introducing dependent features shouldn't trigger metrics reported on the parent feature. If that's the case then we're fine. Tests can be added separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants