Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing options #212

Merged
merged 6 commits into from
Jun 24, 2024
Merged

docs: add missing options #212

merged 6 commits into from
Jun 24, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jun 12, 2024

About the changes

context and createAbortController where not on the list.

@Tymek Tymek force-pushed the feat/docs-update-options branch from 31fe572 to 36c9bd3 Compare June 12, 2024 11:26
@Tymek Tymek marked this pull request as ready for review June 12, 2024 11:26
@Tymek Tymek requested review from kwasniew and thomasheartman June 12, 2024 11:27
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! 😄 A couple minor comments that would be good to address, so it's clear how it's handled. Please check the suggestions as well as the comments. Neither suggestion has all the context that I'd like to see ultimately.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ivarconr and others added 2 commits June 24, 2024 10:16
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
README.md Outdated Show resolved Hide resolved
@Tymek Tymek merged commit 5e105d4 into main Jun 24, 2024
3 checks passed
@Tymek Tymek deleted the feat/docs-update-options branch June 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants