Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move google auth ui behind flag #3606

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented Apr 24, 2023

This moves the access tab for Google Auth behind a flag. The elements are still accessible but hidden by default so this is a soft change. This is a deprecated feature and is on its way out.

Related to https://github.com/ivarconr/unleash-enterprise/pull/444, which locks out the backend from using Google Auth if this flag is not set

UI when the flag is off:
image

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 6:57am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 25, 2023 6:57am

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sighphyre sighphyre merged commit 9521c45 into main Apr 26, 2023
@sighphyre sighphyre deleted the chore/move-google-auth-ui-behind-flag branch April 26, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants