feat: manage filter state in front end #7768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the back end works, the filter won't work yet. We still need to adjust the query parameters.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
This is a different pr
thomasheartman
commented
Aug 6, 2024
Comment on lines
+215
to
+223
| export const EventLog = (props: IEventLogProps) => { | ||
| const { isEnterprise } = useUiConfig(); | ||
| const showFilters = useUiFlag('newEventSearch') && isEnterprise(); | ||
| if (showFilters) { | ||
| return <NewEventLog {...props} />; | ||
| } else { | ||
| return <LegacyEventLog {...props} />; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Split the implementation into two separate components. There is some duplication on what they do, but I think it's easier to keep them like this for now.
There was a problem hiding this comment.
this is the main new bit. It's based on the global feature search.
thomasheartman
added a commit
that referenced
this pull request
Aug 6, 2024
This is just the state management part of #7768. Adds a useEventLogSearch hook. All the filters work except for the date filters. They don't work because the query parameters in the API don't match what's here, but an update to the API is coming in a follow-up. It's a little tricky to handle this because the three different event logs should have slightly different filters, which makes making the type checker happy a bit of a pain. However, I'd like to revisit this in a follow-up PR.
thomasheartman
added a commit
that referenced
this pull request
Aug 7, 2024
…nt search (#7777) Hooks up the new Event search and filtering capabilities to the new Event Log component. In doing so, it also splits the existing EventLog component into two: `LegacyEventLog` and `NewEventLog`. The naming is probably temporary, as the old EventLog isn't really legacy yet. But we can rename them later. The other half of #7768 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
useEventLogSearchhook and hook it up to the existingEventLogcomponent.All the filters work except for the date filters. They don't work because the query parameters in the API don't match what's here, but an update to the API is coming in a follow-up.
This is a little messy because the three different event logs should have slightly different filters, which makes making the type checker happy a bit of a pain. However, I'd like to get back to that in a different follow-up PR later. At the same time, suggestions are welcome.