refactor(firewall): migrate firewall_rules resource to plugin framework #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villevsv-upcloud
force-pushed
the
refactor/migrate-firewall-rules-resource-to-plugin-framework
branch
from
8616d6f
to
b94c4fd
Compare
kangasta
reviewed
Jul 12, 2024
| Required: true, | ||
| ForceNew: true, | ||
| Description: "The unique id of the server to be protected the firewall rules", |
There was a problem hiding this comment.
I think I have used UUID in the other new Id descriptions, but this is a bit different since this refers Id of another resource 🤔
Suggested change
| Description: "The unique id of the server to be protected the firewall rules", | |
| Description: "The UUID of the server to be protected the firewall rules", |
kangasta
reviewed
Jul 12, 2024
| }, | ||
| "firewall_rule": { | ||
| Type: schema.TypeList, | ||
| "firewall_rule": schema.ListNestedAttribute{ |
There was a problem hiding this comment.
Hmm, would ListNestedBlock work if we move this from Attributes to Blocks 🤔 Then this would not require change to protocol version 6 and configuration syntax would stay the same as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: